Fletcher32 #281
Closed
Fletcher32 #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
reviewed
Oct 31, 2023
| # this can be problematic if the encoding of the string is not valid, | ||
| # or reqires too many bytes. Use unicode sting length * 4 to handle all | ||
| # UTF8 strings correctly | ||
| type_info["charSet"] = "H5T_CSET_UTF8" |
There was a problem hiding this comment.
The fletcher32 support should probably be separated from the fixed width UTF8 string support, since I'm since working on some tests for that
There was a problem hiding this comment.
Sorry, I thought this was a branch from master.
I've created a new branch and PR.
|
LGTM. In order for the REST VOL's filter tests to fully pass, HSDS would also need to support (or "support" without implementing) the N-bit filter and the scale-offset filter. |
mattjala
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the fletcher32 filter to be set in the creation property list.
Doesn't actually create a checksum but this will be helpful for compatibility with existing apps.